Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python add-on for developments tests #1678

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

CastagnaIT
Copy link
Collaborator

@CastagnaIT CastagnaIT commented Oct 1, 2024

Description

I've been thinking about this for years now
I think it can be useful to provide a simple testing method for us,
and also for new developers or users who want to try using ISA or participate in some way to tests
Having an extensible python add-on for tests i think is best
and also can also shown how to integrate isa to python add-ons

Whole menu data is contained on menu_data.py file, json based so can be extended as you wish,
that file contains some more instructions, but it is imo quite understandable

i intentionally limited the add-on compatibility to minimum Kodi v21, this because on old Kodi's we have older (deprecated/now removed) properties that otherwise will made more complex all the add-on for nothing, and anyway its designed for the future not for outdated versions of Kodi

there are different ways to think about writing this add-on and certainly everyone will have different ideas, but i think it's a wayto start

I thought of adding it directly into this repository, because it needs to be kept in line with the binary changes
Is not thought to be officially published in the Kodi repository

all things can be discusses if you think it is appropriate

here some screenshots while running (just zip the main folder and install it as usual):
immagine
immagine
immagine
immagine

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Its a tester add-on, separate from the binary add-on sources

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added the RFC PR submitted for gathering feedback label Oct 1, 2024
@CastagnaIT
Copy link
Collaborator Author

CC @glennguy @matthuisman thoughts?

@matthuisman
Copy link
Contributor

this is really neat!!

I remember years ago i started creating a repo of .strm files for different types of streams (https://github.com/matthuisman/ia_tests)

This is similiar but in add-on form :)
Hopefully it also makes it easier for you guys to test PRs dont break any existing working streams :)
Unittests are great, but runtime testing is also great

@CastagnaIT
Copy link
Collaborator Author

you have a good list, most of them are customized and cant fit this addon
but maybe someone could be added here

@glennguy
Copy link
Contributor

glennguy commented Oct 9, 2024

Great idea. I agree with keeping it in this repo

@CastagnaIT
Copy link
Collaborator Author

if you have some other free stream that you want include let me know

@CastagnaIT CastagnaIT merged commit 57876c9 into xbmc:Piers Oct 30, 2024
3 of 10 checks passed
@CastagnaIT CastagnaIT deleted the py_addon branch October 30, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC PR submitted for gathering feedback v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants